Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Component Migration #6548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JamesHollyer
Copy link
Contributor

@JamesHollyer JamesHollyer commented Aug 16, 2023

Motivation for features / changes

The legacy components are being deprecated. This is a big step in moving to the new components

Technical description of changes

This was done with a complicated find and replace which included manual pruning. After the find and replace the only other changes are in the mat-slider components as the new mat-sliders have a completely different structure with the thumb as a child component. This mat-slider change in the image card allowed for a cleanup of some weird logic.

Significantly I also change the mat.all-legacy-component-themes call to mat.all-component-themes in the _tb_theme.template.scss file.

This PR causes a lot of styling issues which will need to be resolved before syncing or releasing.

Screenshots of UI changes (or N/A)

Screenshot 2023-08-16 at 10 32 51 AM Screenshot 2023-08-16 at 10 33 34 AM

Detailed steps to verify changes work correctly (as executed by you)

Alternate designs / implementations considered (or N/A)

@JamesHollyer JamesHollyer force-pushed the MigrateMatCheckbox branch 4 times, most recently from 8dcec64 to 7169a2f Compare August 17, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant